linux-kernel - Re: [PATCH] scsi_dh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4EEDFBCF.4040802@nod.at>
Date:	Sun, 18 Dec 2011 15:42:23 +0100
From:	Richard Weinberger <richard@....at>
To:	"Moger, Babu" <Babu.Moger@...app.com>
CC:	JBottomley@...allels.com, Somasundaram.Krishnasamy@....com,
	yanling.qi@....com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi_dh_rdac: Fix error path

Am 18.11.2011 15:34, schrieb Moger, Babu:
> Looks good to me..
> 
>> -----Original Message-----
>> From: Richard Weinberger [mailto:richard@....at]
>> Sent: Thursday, November 17, 2011 6:44 PM
>> To: JBottomley@...allels.com
>> Cc: Moger, Babu; Somasundaram.Krishnasamy@....com; yanling.qi@....com;
>> linux-scsi@...r.kernel.org; linux-kernel@...r.kernel.org; Richard
>> Weinberger
>> Subject: [PATCH] scsi_dh_rdac: Fix error path
>>
>> If create_singlethread_workqueue() failes, rdac_init should fail too.
>>
>> Signed-off-by: Richard Weinberger <richard@....at>
>> ---
>>  drivers/scsi/device_handler/scsi_dh_rdac.c |    2 ++
>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/scsi/device_handler/scsi_dh_rdac.c
>> b/drivers/scsi/device_handler/scsi_dh_rdac.c
>> index 1d31279..2802394 100644
>> --- a/drivers/scsi/device_handler/scsi_dh_rdac.c
>> +++ b/drivers/scsi/device_handler/scsi_dh_rdac.c
>> @@ -934,6 +934,8 @@ static int __init rdac_init(void)
>>  	if (!kmpath_rdacd) {
>>  		scsi_unregister_device_handler(&rdac_dh);
>>  		printk(KERN_ERR "kmpath_rdacd creation failed.\n");
>> +
>> +		r = -EINVAL;
>>  	}
>>  done:
>>  	return r;
>> --
>> 1.7.7.3
> 

James,

can you please pickup this patch?

Thanks,
//richard



Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)