linux-kernel - Re: [PATCH] scsi_dh: Fix return value of scsi_dh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4EEDFC16.90303@nod.at>
Date:	Sun, 18 Dec 2011 15:43:34 +0100
From:	Richard Weinberger <richard@....at>
To:	JBottomley@...allels.com
CC:	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi_dh: Fix return value of scsi_dh_attach()

Am 18.11.2011 00:34, schrieb Richard Weinberger:
> scsi_dh_attach() should return a negative value on error.
> 
> Signed-off-by: Richard Weinberger <richard@....at>
> ---
>  include/scsi/scsi_dh.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/scsi/scsi_dh.h b/include/scsi/scsi_dh.h
> index e3f2db2..e07ab10 100644
> --- a/include/scsi/scsi_dh.h
> +++ b/include/scsi/scsi_dh.h
> @@ -74,7 +74,7 @@ static inline int scsi_dh_handler_exist(const char *name)
>  }
>  static inline int scsi_dh_attach(struct request_queue *req, const char *name)
>  {
> -	return SCSI_DH_NOSYS;
> +	return -SCSI_DH_NOSYS;
>  }
>  static inline void scsi_dh_detach(struct request_queue *q)
>  {

James,

can you please pickup this patch?

Thanks,
//richard


Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)