linux-kernel - Re: [PATCH 13/15] module_param: make bool parameters really bool (sound)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h7h1slx7i.wl%tiwai@suse.de>
Date:	Mon, 19 Dec 2011 10:36:33 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	lkml - Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Pawel Moll <pawel.moll@....com>,
	Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org
Subject: Re: [PATCH 13/15] module_param: make bool parameters really bool (sound)

At Mon, 19 Dec 2011 12:25:40 +1030,
Rusty Russell wrote:
> 
> On Thu, 15 Dec 2011 13:33:50 +0100, Takashi Iwai <tiwai@...e.de> wrote:
> > At Thu, 15 Dec 2011 13:49:36 +1030,
> > Rusty Russell wrote:
> > > 
> > > module_param(bool) used to counter-intuitively take an int.  In
> > > fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
> > > trick.
> > > 
> > > It's time to remove the int/unsigned int option.  For this version
> > > it'll simply give a warning, but it'll break next kernel version.
> > > 
> > > Cc: Jaroslav Kysela <perex@...ex.cz>
> > > Cc: Takashi Iwai <tiwai@...e.de>
> > > Cc: alsa-devel@...a-project.org
> > > Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>
> > 
> > Acked-by: Takashi Iwai <tiwai@...e.de>
> > 
> > (Maybe it'd be good to change with true and false instead of 1 and 0,
> >  too.  But it's subtle things and we don't have to mix up in a single
> >  patch.)
> > 
> > Rusty, would you like to merge from your tree, or shall I merge
> > through sound tree?
> 
> Please take it :)
> 
> I'll take the bint one, since that's got other dependencies, but this
> one is pure cleanup.

OK, I merged it now.


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/