linux-kernel - Re: [PATCH V3 01/21] ext4: Move extra inode read to a new function.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <BB5BC380-D840-4AD8-80CC-C320AF780FEF@whamcloud.com>
Date:	Mon, 19 Dec 2011 09:32:41 +0100
From:	Andreas Dilger <adilger@...mcloud.com>
To:	Tao Ma <tm@....ma>
Cc:	"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
	"adilger@...ger.ca" <adilger@...ger.ca>,
	"tytso@....edu" <tytso@....edu>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH V3 01/21] ext4: Move extra inode read to a new function.

On 2011-12-18, at 15:24, Tao Ma <tm@....ma> wrote:

> From: Tao Ma <boyu.mt@...bao.com>
> 
> Currently, in ext4_iget we do a simple check to see whether
> there does exist some information starting from the end
> of i_extra_size. With inline data added, this procedure
> is more complicated. So move it to a new function named
> ext4_iget_extra_inode.
> 
> +        } else
> +            ext4_iget_extra_inode(inode, raw_inode, ei);
>    } else

(style) if one half of an if-else uses braces then the other half should as well. 

Cheers, Andreas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/