linux-kernel - Re: [PATCH] scsi_dh: Fix return value of scsi_dh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4EEF30C2.4040803@nod.at>
Date:	Mon, 19 Dec 2011 13:40:34 +0100
From:	Richard Weinberger <richard@....at>
To:	Hannes Reinecke <hare@...e.de>
CC:	James Bottomley <James.Bottomley@...senPartnership.com>,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi_dh: Fix return value of scsi_dh_attach()

Hannes,

On 19.12.2011 12:59, Hannes Reinecke wrote:
> Nack.
>
> This patch is wrong.
>
> scsi_dh_attach() (and, incidentally, scsi_dh_set_params()) should
> return a standard error value. SCSI_DH_XXX are internal to
> device_handler and should never see the light of day.
>

Thanks for your feedback.
Both scsi_dh_attach() and scsi_dh_set_params() should
return -ENODEV, right?

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/