linux-kernel - Re: [PATCH] MXSFB: Fix driver registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4EEF55AC.6060107@gmx.de>
Date:	Mon, 19 Dec 2011 15:18:04 +0000
From:	Florian Tobias Schandinat <FlorianSchandinat@....de>
To:	Shawn Guo <shawn.guo@...aro.org>
CC:	Marek Vasut <marek.vasut@...il.com>, linux-kernel@...r.kernel.org,
	Wolfgang Denk <wd@...x.de>, Stefano Babic <sbabic@...x.de>,
	Huang Shijie <b32955@...escale.com>,
	Axel Lin <axel.lin@...il.com>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	linux-fbdev@...r.kernel.org
Subject: Re: [PATCH] MXSFB: Fix driver registration

Hi Marek,

can you please resend the patch to me and the fbdev mailing list, preferably
with all Ack's you received until now included.

On 12/19/2011 01:51 PM, Shawn Guo wrote:
> Cc-ed Florian and linux-fbdev@...r.kernel.org, as I guess Florian is
> the person who will take this patch.

Thanks, I will. I guess you wanted to Ack this patch?


Thanks,

Florian Tobias Schandinat

> 
> -- Regards,Shawn
> On 18 December 2011 08:58, Marek Vasut <marek.vasut@...il.com> wrote:
>> The driver should be registered with mxsfb_driver, not with mxsfb_devtype.
>> This caused obvious null pointer dereference and crash.
>>
>> Signed-off-by: Marek Vasut <marek.vasut@...il.com>
>> Cc: Wolfgang Denk <wd@...x.de>
>> Cc: Stefano Babic <sbabic@...x.de>
>> Cc: Shawn Guo <shawn.guo@...aro.org>
>> Cc: Huang Shijie <b32955@...escale.com>
>> Cc: Axel Lin <axel.lin@...il.com>
>> Cc: Sascha Hauer <s.hauer@...gutronix.de>
>> ---
>>  drivers/video/mxsfb.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
>> index 18742c2..d29c7c0 100644
>> --- a/drivers/video/mxsfb.c
>> +++ b/drivers/video/mxsfb.c
>> @@ -902,7 +902,7 @@ static struct platform_driver mxsfb_driver = {
>>        },
>>  };
>>
>> -module_platform_driver(mxsfb_devtype);
>> +module_platform_driver(mxsfb_driver);
>>
>>  MODULE_DESCRIPTION("Freescale mxs framebuffer driver");
>>  MODULE_AUTHOR("Sascha Hauer, Pengutronix");
>> --
>> 1.7.6.4
>>
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/