linux-kernel - Re: Android low memory killer vs. memory pressure notifications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4EEF75A0.2080503@gmail.com>
Date:	Mon, 19 Dec 2011 12:34:24 -0500
From:	KOSAKI Motohiro <kosaki.motohiro@...il.com>
To:	Anton Vorontsov <anton.vorontsov@...aro.org>
CC:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Arve Hjønnevåg 
	<arve@...roid.com>, Rik van Riel <riel@...hat.com>,
	Pavel Machek <pavel@....cz>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Rientjes <rientjes@...gle.com>,
	Michal Hocko <mhocko@...e.cz>,
	John Stultz <john.stultz@...aro.org>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: Android low memory killer vs. memory pressure notifications

>> + read_lock(&tasklist_lock);
>
> Crazy inefficient. mere slab shrinker shouldn't take tasklist_lock.
> Imagine if tasks are much plenty...
>
> Moreover, if system have plenty file cache, any process shouldn't killed
> at all! That's fundamental downside of this patch.

In addition, this code is reused a lot of code of oom-killer. But it is 
bad idea. oom killer is really exceptional case. then it don't pay 
attention faster processing. But, no free memory is not rare. we don't 
have much free memory EVERY TIME. because we have file cache.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/