linux-kernel - Re: [PATCH v2] Input: bcm5974

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201112191842.08635.oliver@neukum.org>
Date:	Mon, 19 Dec 2011 18:42:08 +0100
From:	Oliver Neukum <oliver@...kum.org>
To:	"Henrik Rydberg" <rydberg@...omail.se>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	Matthew Garrett <mjg@...hat.com>
Subject: Re: [PATCH v2] Input: bcm5974 - Fix USB autosuspend

Am Montag, 19. Dezember 2011, 18:02:03 schrieb Henrik Rydberg:
>  static int bcm5974_suspend(struct usb_interface *iface, pm_message_t message)
> @@ -870,6 +884,9 @@ static int bcm5974_probe(struct usb_interface *iface,
>                          dev->tp_data, dev->cfg.tp_datalen,
>                          bcm5974_irq_trackpad, dev, 1);
>  
> +       /* Required for autosuspend */
> +       iface->needs_remote_wakeup = 1;
> +
>         /* create bcm5974 device */
>         usb_make_path(udev, dev->phys, sizeof(dev->phys));
>         strlcat(dev->phys, "/input0", sizeof(dev->phys));

It is not nice to set needs_remote_wakeup on suspend() because
it influences the decision of usbcore to suspend at all, in particular
manually set quirks will not be fully honored if you do it this way.
In addition it will never be reset, even as the device is closed.

Please set it in open() and clear it in close()

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/