linux-kernel - RE: [PATCH] pinctrl: rename U300 ans SIRF pin controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF176BE92A8E@HQMAIL01.nvidia.com>
Date:	Mon, 19 Dec 2011 10:29:52 -0800
From:	Stephen Warren <swarren@...dia.com>
To:	Linus Walleij <linus.walleij@...ricsson.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	Grant Likely <grant.likely@...retlab.ca>,
	Barry Song <21cnbao@...il.com>,
	Shawn Guo <shawn.guo@...escale.com>,
	Thomas Abraham <thomas.abraham@...aro.org>,
	Dong Aisheng <dong.aisheng@...aro.org>,
	Rajendra Nayak <rajendra.nayak@...aro.org>,
	Haojian Zhuang <haojian.zhuang@...vell.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Rongjun Ying <Rongjun.Ying@....com>,
	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
Subject: RE: [PATCH] pinctrl: rename U300 ans SIRF pin controllers

Linus Walleij wrote at Sunday, December 18, 2011 3:47 PM:
> For stringen order, rename the pinmux-* pin controllers to

I'm not sure what "stringen order" is; perhaps "consistency"?

> pinctrl-* and also rename the Kconfig symbols and in-kernel
> users.
> 
> Cc: Rongjun Ying <Rongjun.Ying@....com>
> Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>

Acked-by: Stephen Warren <swarren@...dia.com>

Just one question though:

> diff --git a/drivers/pinctrl/pinmux-sirf.c b/drivers/pinctrl/pinctrl-sirf.c
> similarity index 100%
> rename from drivers/pinctrl/pinmux-sirf.c
> rename to drivers/pinctrl/pinctrl-sirf.c
> diff --git a/drivers/pinctrl/pinmux-u300.c b/drivers/pinctrl/pinctrl-u300.c
> similarity index 100%
> rename from drivers/pinctrl/pinmux-u300.c
> rename to drivers/pinctrl/pinctrl-u300.c

Do you want to change the DRIVER_NAME define in those two drivers and
s/pinmux/pinctrl/ there? Perhaps that's not a good idea, but I thought
I'd ask in case you meant to.

-- 
nvpublic

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/