linux-kernel - Re: [PATCH] MXSFB: Fix driver registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111219080044.GB27267@pengutronix.de>
Date:	Mon, 19 Dec 2011 09:00:44 +0100
From:	Sascha Hauer <s.hauer@...gutronix.de>
To:	Marek Vasut <marek.vasut@...il.com>
Cc:	linux-kernel@...r.kernel.org, Wolfgang Denk <wd@...x.de>,
	Stefano Babic <sbabic@...x.de>,
	Shawn Guo <shawn.guo@...aro.org>,
	Huang Shijie <b32955@...escale.com>,
	Axel Lin <axel.lin@...il.com>
Subject: Re: [PATCH] MXSFB: Fix driver registration

On Sun, Dec 18, 2011 at 01:58:07AM +0100, Marek Vasut wrote:
> The driver should be registered with mxsfb_driver, not with mxsfb_devtype.
> This caused obvious null pointer dereference and crash.
> 
> Signed-off-by: Marek Vasut <marek.vasut@...il.com>
> Cc: Wolfgang Denk <wd@...x.de>
> Cc: Stefano Babic <sbabic@...x.de>
> Cc: Shawn Guo <shawn.guo@...aro.org>
> Cc: Huang Shijie <b32955@...escale.com>
> Cc: Axel Lin <axel.lin@...il.com>
> Cc: Sascha Hauer <s.hauer@...gutronix.de>

Acked-by: Sascha Hauer <s.hauer@...gutronix.de>

> ---
>  drivers/video/mxsfb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
> index 18742c2..d29c7c0 100644
> --- a/drivers/video/mxsfb.c
> +++ b/drivers/video/mxsfb.c
> @@ -902,7 +902,7 @@ static struct platform_driver mxsfb_driver = {
>  	},
>  };
>  
> -module_platform_driver(mxsfb_devtype);
> +module_platform_driver(mxsfb_driver);
>  
>  MODULE_DESCRIPTION("Freescale mxs framebuffer driver");
>  MODULE_AUTHOR("Sascha Hauer, Pengutronix");
> -- 
> 1.7.6.4
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/