linux-kernel - Re: [PATCH 2/2] staging: vt6656: Remove useless function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111220063716.GH17353@mwanda>
Date:	Tue, 20 Dec 2011 09:37:16 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Marcos Paulo de Souza <marcos.mage@...il.com>
Cc:	gregkh@...e.de, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] staging: vt6656: Remove useless function

On Tue, Dec 20, 2011 at 01:07:27AM +0000, Marcos Paulo de Souza wrote:
>  /*
>   * Wireless Handler : get protocol name
>   */
> @@ -1936,7 +1921,6 @@ int iwctl_siwmlme(struct net_device *dev,
>  /*
>  static const iw_handler		iwctl_handler[] =
>  {
> -	(iw_handler) iwctl_commit,      // SIOCSIWCOMMIT

Nope.  This doesn't work.  It moves everything in the array to the
wrong position.  It should be replaced with NULL or better yet, the
whole array should be rewritten with like:

static const iw_handler iwctl_handler[] = {
	[SIOCGIWNAME]  = (iw_handler) iwctl_giwname,
	[SIOCGIWRANGE] = (iw_handler) iwctl_giwrange,
	...

The NULLs could be left out then.

>  	(iw_handler) iwctl_giwname,     // SIOCGIWNAME
>  	(iw_handler) NULL,				// SIOCSIWNWID
>  	(iw_handler) NULL,				// SIOCGIWNWID
> @@ -1998,7 +1982,7 @@ static const iw_handler		iwctl_handler[] =
>  
>  static const iw_handler		iwctl_handler[] =
>  {
> -	(iw_handler) iwctl_commit,      // SIOCSIWCOMMIT
> +	(iw_handler) 0,      /* SIOCSIWCOMMIT */

This should be NULL not zero because it's a pointer.  (Style issue,
not a bug).

regards,
dan carpenter


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)