linux-kernel - Re: [PATCH v2] usb: musb: fix pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111220113823.GJ31842@legolas.emea.dhcp.ti.com>
Date:	Tue, 20 Dec 2011 13:38:25 +0200
From:	Felipe Balbi <balbi@...com>
To:	Felipe Contreras <felipe.contreras@...ia.com>
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-omap <linux-omap@...r.kernel.org>,
	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Jarkko Nikula <jarkko.nikula@...mer.com>,
	Felipe Contreras <felipe.contreras@...il.com>,
	stable@...r.kernel.org, Hema HK <hemahk@...com>
Subject: Re: [PATCH v2] usb: musb: fix pm_runtime mismatch

On Mon, Dec 19, 2011 at 10:01:54PM +0200, Felipe Contreras wrote:
> From: Felipe Contreras <felipe.contreras@...il.com>
> 
> In musb_init_controller() there's a pm_runtime_put(), but there's no
> pm_runtime_get(), which creates a mismatch that causes the driver to
> sleep when it shouldn't.
> 
> This was introduced in 7acc619[1], but it wasn't triggered in my setup
> until 18a2689[2] was merged to Linus' branch at point df0914[3]. IOW;
> when PM is working as it was supposed to.
> 
> However, it seems most of the time this is used in a way that keeps the
> counter above 0, so nobody noticed. Also, it seems to depend on the
> configuration used in versions before 3.1, but not later (or in it).
> 
> I found the problem by loading isp1704_charger before any usb gadgets:
> http://article.gmane.org/gmane.linux.kernel/1226122
> 
> All versions after 2.6.39 are affected.
> 
> [1] usb: musb: Idle path retention and offmode support for OMAP3
> [2] OMAP2+: musb: hwmod adaptation for musb registration
> [3] Merge branch 'omap-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6
> 
> Cc: stable@...r.kernel.org
> Cc: Hema HK <hemahk@...com>
> Signed-off-by: Felipe Contreras <felipe.contreras@...il.com>

applied, thanks

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)