lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 20 Dec 2011 15:38:05 +0000 From: David Howells <dhowells@...hat.com> To: Andi Kleen <andi@...stfloor.org> Cc: dhowells@...hat.com, linux-arch@...r.kernel.org, mingo@...e.hu, linux-kernel@...r.kernel.org Subject: Re: [PATCH 3/7] Add assertion checking macros Andi Kleen <andi@...stfloor.org> wrote: > David Howells <dhowells@...hat.com> writes: > > > > There is no need to display val here in the case the expression fails > > since it can only be 0. If this fails, it produces an error like the > > following: > > > > ------------[ cut here ]------------ > > kernel BUG at fs/fscache/main.c:109! > > ASSERTION FAILED > > It would be nice to display the expression here like an user space > assert. While it can be looked up in the source it would > make quick eyeballing easier. > > Probably wouldn't cost too much additional text size? It can easily be made selectable. I don't think text size should be much of an issue - but it will also add a bunch of strings (preprocessed expressions) to the rodata, and I'm not sure how big those can get - particularly if they've got nested macros within (test_bit() for example). David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists