linux-kernel - Re: [PATCH 2/2] tracing, sched: Add a new tracepoint for sleeptime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1324408795.5916.73.camel@gandalf.stny.rr.com>
Date:	Tue, 20 Dec 2011 14:19:55 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Arun Sharma <asharma@...com>
Cc:	linux-kernel@...r.kernel.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	Arnaldo Carvalho de Melo <acme@...radead.org>,
	Andrew Vagin <avagin@...nvz.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH 2/2] tracing, sched: Add a new tracepoint for sleeptime

On Tue, 2011-12-20 at 10:22 -0800, Arun Sharma wrote:
> On 12/20/11 10:16 AM, Steven Rostedt wrote:
> 
> >> +#ifdef CREATE_TRACE_POINTS
> >
> > Why the #ifdef? a static inline is fine to keep in the open. If nothing
> > uses it, then it just wont be used or defined.
> >
> 
> Without the ifdef I get:
> 
> In file included from include/trace/define_trace.h:80,
>                   from include/trace/events/sched.h:445,
>                   from kernel/sched/core.c:86:
> include/trace/events/sched.h:366: error: redefinition of 
> ‘trace_get_sleeptime’
> include/trace/events/sched.h:366: note: previous definition of 
> ‘trace_get_sleeptime’ was here
> 
> So I shamelessly copied what the other static inline function in the 
> file does.

Ah, OK, it's because of the duplicate includes. Still ugly though. But
we can clean that up later.


> 
> I also noticed that sched_stat_sleeptime() is very similar to 
> sched_stat_sleep(). The latter covers sleeps but not iowait and doesn't 
> include the scheduler latency. Let me know if you think this is a show 
> stopper that needs a rename.

what about sched_stat_iowait() too. As for latency, I don't know. That's
more Peter's decision.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/