| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAMP44s1m9oXpiw506kE6JJn5xO+oCRL8B0UixUf4X=Ew00=wHA@mail.gmail.com> Date: Tue, 20 Dec 2011 21:43:45 +0200 From: Felipe Contreras <felipe.contreras@...il.com> To: balbi@...com Cc: linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org, Greg Kroah-Hartman <gregkh@...e.de>, Jiri Kosina <trivial@...nel.org> Subject: Re: [PATCH 1/3] usb: musb: fix pm_runtime mismatches On Tue, Dec 20, 2011 at 1:19 PM, Felipe Balbi <balbi@...com> wrote: > On Mon, Dec 19, 2011 at 10:20:09PM +0200, Felipe Contreras wrote: >> On Mon, Dec 19, 2011 at 10:11 AM, Felipe Balbi <balbi@...com> wrote: >> > On Fri, Dec 16, 2011 at 01:05:08AM +0200, Felipe Contreras wrote: >> >> Properly call pm_runtime_put() afer pm_runttime_get() on errors. >> >> >> >> Untested. >> > >> > sorry, but I'm not applying untested patches. I need someone to give a >> > Tested-by. >> >> I'm pretty sure most people don't test the exit paths, but fine, don't >> apply them. Who needs power management anyway. > > if it wasn't tested you can't claim $SUBJECT makes PM magically work. It's clear from the code, no need to test to see that pm_runtime_get() is called but not pm_runtime_put(), thus the device remains active, thus PM would not work after that. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists