lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 20 Dec 2011 15:58:43 -0800 From: Stephen Warren <swarren@...dia.com> To: Dong Aisheng <b29396@...escale.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> CC: "linus.walleij@...ricsson.com" <linus.walleij@...ricsson.com>, "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>, "rob.herring@...xeda.com" <rob.herring@...xeda.com>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "kernel@...gutronix.de" <kernel@...gutronix.de>, "cjb@...top.org" <cjb@...top.org>, "devicetree-discuss@...ts.ozlabs.org" <devicetree-discuss@...ts.ozlabs.org> Subject: RE: [RFC PATCH v3 1/5] dt: add of_get_child_count helper function Dong Aisheng wrote at Tuesday, December 20, 2011 10:41 AM: > From: Dong Aisheng <dong.aisheng@...aro.org> > > Currently most code to get child count in kernel are almost same, > add a helper to implement this function for dt to use. > diff --git a/include/linux/of.h b/include/linux/of.h > +static inline int of_get_child_count(const struct device_node *np) > +{ > + return -ENOSYS; > +} Wouldn't it be better to return 0 here? -ENOSYS would be fine if the function returned an error code, but it's really returning a count, and other "dummy" functions that return data return 0/NULL already. This would also allow you to just use the value directly in all cases rather than having to check for a < 0 error case. -- nvpublic -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists