lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 21 Dec 2011 07:24:05 +0100
From:	"Michal Nazarewicz" <mina86@...a86.com>
To:	"Minchan Kim" <minchan@...nel.org>
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	linux-mm <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] vmalloc: remove #ifdef in function body

On Wed, 21 Dec 2011 07:22:32 +0100, Minchan Kim <minchan@...nel.org> wrote:

> On Wed, Dec 21, 2011 at 07:13:49AM +0100, Michal Nazarewicz wrote:
>> On Wed, 21 Dec 2011 06:17:59 +0100, Minchan Kim <minchan@...nel.org> wrote:
>> >We don't like function body which include #ifdef.
>> >If we can, define null function to go out compile time.
>> >It's trivial, no functional change.
>>
>> It actually adds “flush_tlb_kenel_range()” call to the function so there
>> is functional change.
>
> Sorry. I can't understand your point.
> Why does it add flush_tlb_kernel_range in case of !CONFIG_DEBUG_PAGEALLOC?

Uh, sorry, I've totally misread the function.  Never mind my comment.

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@...gle.com>--------------ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ