linux-kernel - Re: [PATCH] vmalloc: remove #ifdef in function body

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <op.v6tug3vi3l0zgt@mpn-glaptop>
Date:	Wed, 21 Dec 2011 07:47:17 +0100
From:	"Michal Nazarewicz" <mina86@...a86.com>
To:	"Joe Perches" <joe@...ches.com>
Cc:	"Minchan Kim" <minchan@...nel.org>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	linux-mm <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] vmalloc: remove #ifdef in function body

On Wed, 21 Dec 2011 07:32:36 +0100, Joe Perches <joe@...ches.com> wrote:

> On Wed, 2011-12-21 at 07:21 +0100, Michal Nazarewicz wrote:
>> it seems the community prefers
>> having ifdefs outside of the function.
>
> Some do, some don't.
>
> http://comments.gmane.org/gmane.linux.network/214543

This patch that you pointed to is against “#ifdefs are ugly” style
described in Documentation/SubmittingPatches.

> If it's not in coding style, I suggest
> it should be changed if it doesn't
> add some other useful value.

That my be true.  I guess no one took time to adding it to the document.

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@...gle.com>--------------ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/