linux-kernel - Re: [PATCH] block: fix blk_queue_end

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4EF18129.7030407@tao.ma>
Date:	Wed, 21 Dec 2011 14:48:09 +0800
From:	Tao Ma <tm@....ma>
To:	Meelis Roos <mroos@...ux.ee>
CC:	Dan Williams <dan.j.williams@...el.com>, axboe@...nel.dk,
	Tao Ma <boyu.mt@...bao.com>,
	Linux Kernel list <linux-kernel@...r.kernel.org>,
	linux-scsi@...r.kernel.org, Ed Nadolski <edmund.nadolski@...el.com>
Subject: Re: [PATCH] block: fix blk_queue_end_tag()

On 12/21/2011 02:36 PM, Meelis Roos wrote:
>>> -	if (unlikely(tag >= bqt->max_depth)) {
>>> +	if (WARN_ONCE(tag >= bqt->real_max_depth,
>>> +		      "%s: tag %d greater than tag map size: %d\n",
>>> +		      __func__, tag, bqt->real_max_depth)) {
>>>  		/*
>>>  		 * This can happen after tag depth has been reduced.
>> Please also change the comments here since it should never happen in the
>> right workload.
> 
> What do you mean by right workload? Normal workload?
yeah, so real_max_depth is the maximum depth we ever have. So in normal
case(shrinking queue depth is also a normal user case), we should never
arrive here. In another word, if tag >= real_max_depth, we should have a
bug in the kernel.

Thanks
Tao
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/