linux-kernel - RE: [PATCH v2] davinci: DA850 EVM: OHCI platform code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DF0F476B391FA8409C78302C7BA518B6051CB9@DBDE01.ent.ti.com>
Date:	Wed, 21 Dec 2011 09:56:55 +0000
From:	"Nori, Sekhar" <nsekhar@...com>
To:	"Manjunathappa, Prakash" <prakash.pm@...com>,
	"davinci-linux-open-source@...ux.davincidsp.com" 
	<davinci-linux-open-source@...ux.davincidsp.com>,
	Sergei Shtylyov <sshtylyov@...sta.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	"Gupta, Ajay Kumar" <ajay.gupta@...com>
Subject: RE: [PATCH v2] davinci: DA850 EVM: OHCI platform code

Hi Prakash,

On Wed, Dec 21, 2011 at 12:50:02, Manjunathappa, Prakash wrote:
> From: Ajay Kumar Gupta <ajay.gupta@...com>
> 
> On this board the OHCI port's power control and over-current signals from
> TPS2065 power switch are connected via GPIO2[4] and GPIO6[13] respectively,
> so we can implement the DA8xx OHCI glue layer's hooks for overriding the
> root hub port's power and over-current status bits.
> 
> We also have to properly set up the clocking mode in the CFGCHIP2 register,
> so that internal 24 MHz reference clock is fed to the USB 2.0 (MUSB) PHY and
> its output is used to clock the USB 1.1 (OHCI) PHY...
> 
> Signed-off-by: Ajay Kumar Gupta <ajay.gupta@...com>
> Signed-off-by: Manjunathappa, Prakash <prakash.pm@...com>

This is the third copy of OHCI platform setup code which is almost
the same except for the GPIO numbers. Can we attempt to consolidate
the GPIO case under drivers/usb/host/ohci-da8xx.c glue layer itself?
Of course, here should be a provision for non-GPIO based implementation
as well.

Sergei, any thoughts, comments?

Thanks,
Sekhar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/