linux-kernel - Re: [RFC 4/5] x86, perf: implements lwp-perf-integration (rc1)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111221120055.GA4040@elte.hu>
Date:	Wed, 21 Dec 2011 13:00:55 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Vince Weaver <vweaver1@...s.utk.edu>
Cc:	Avi Kivity <avi@...hat.com>,
	Robert Richter <robert.richter@....com>,
	Benjamin Block <bebl@...eta.org>,
	Hans Rosenfeld <hans.rosenfeld@....com>, hpa@...or.com,
	tglx@...utronix.de, suresh.b.siddha@...el.com, eranian@...gle.com,
	brgerst@...il.com, Andreas.Herrmann3@....com, x86@...nel.org,
	linux-kernel@...r.kernel.org,
	Benjamin Block <benjamin.block@....com>
Subject: Re: [RFC 4/5] x86, perf: implements lwp-perf-integration (rc1)


* Vince Weaver <vweaver1@...s.utk.edu> wrote:

> > But as we told you previously, you could use RDPMC under 
> > perf as well, last i checked PeterZ posted experimental 
> > patches for that. Peter, what's the status of that?
> 
> yes.  If you checked the benchmark results I showed, you'd 
> have seen that I run tests against that patchset too, and it's 
> really only marginally better that the current perf_event 
> stuff.  I might have written the benchmark poorly, [...]

It is significantly faster for the self-monitoring case - which 
is a pretty niche usecase btw.

Have a look at how the 'perf test' self-test utilizes RDPMC in 
these commits in tip:perf/fast:

 08aa0d1f376e: perf tools: Add x86 RDPMC, RDTSC test
 e3f3541c19c8: perf: Extend the mmap control page with time (TSC) fields
 0c9d42ed4cee: perf, x86: Provide means for disabling userspace RDPMC
 fe4a330885ae: perf, x86: Implement user-space RDPMC support, to allow fast, user-space access to self-monitoring counters
 365a4038486b: perf: Fix mmap_page::offset computation
 35edc2a5095e: perf, arch: Rework perf_event_index()
 9a0f05cb3688: perf: Update the mmap control page on mmap()

You can find these commits in today's -tip. Overhead should be 
somewhere around 50 cycles per call (i suspect it could 
optimized more), which is a fraction of what a syscall is 
costing.

> [...] but that's mainly because as-posted the documentation 
> for how to use that patchset is a bit unclear.

In your world there's always someone else to blame.

The thing is, *you* are interested in this niche feature, PeterZ 
not so much.

You made a false claim that perf cannot use RDPMC and PeterZ has 
proven you wrong once again. Your almost non-stop whining and 
the constant misrepresentations you make are not very 
productive.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/