linux-kernel - oprofile patch broke s390 build in tip/perf/core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1324488646.5916.107.camel@gandalf.stny.rr.com>
Date:	Wed, 21 Dec 2011 12:30:46 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	LKML <linux-kernel@...r.kernel.org>,
	linux-s390 <linux-s390@...r.kernel.org>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Robert Richter <robert.richter@....com>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Heiko Carstens <heiko.carstens@...ibm.com>
Subject: oprofile patch broke s390 build in tip/perf/core

Hi,

In doing my tests last night before sending out my patch series this
morning, I found that s390 build didn't work, but it wasn't due to my
patches. I removed all my patches and built with latest mainline (which
builds fine), and then merged the current tip/perf/core. The result
didn't build.

I kicked off a ktest git bisect with last night's Linus tree as good,
and with the merged in tip/perf/core as bad. It ended up with this patch
that broke the build (which looks like a likely suspect).


The break is this:

  LD      .tmp_vmlinux1
arch/s390/oprofile/built-in.o: In function `oprofile_arch_exit':
(.text+0x3f52): undefined reference to `oprofile_timer_exit'
make[1]: *** [.tmp_vmlinux1] Error 1
make: *** [sub-make] Error 2

The patch the bisect found that breaks the build is this:

commit 75c43a20b220f885c39ffa7cdbbb1191e257a9a9
Author: Robert Richter <robert.richter@....com>
Date:   Fri Oct 14 15:46:10 2011 +0200

    oprofile: Remove exit function for timer mode
    
    Remove exit functions by moving init/exit code to oprofile's setup/
    shutdown functions. Doing so the oprofile module exit code will be
    easier and less error-prone.
    
    Signed-off-by: Robert Richter <robert.richter@....com>


-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/