[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20111221184811.GC961@sequoia.sous-sol.org>
Date: Wed, 21 Dec 2011 10:48:11 -0800
From: Chris Wright <chrisw@...s-sol.org>
To: "Hao, Xudong" <xudong.hao@...el.com>
Cc: Chris Wright <chrisw@...s-sol.org>,
"dwmw2@...radead.org" <dwmw2@...radead.org>,
"iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"Zhang, Xiantao" <xiantao.zhang@...el.com>,
"kvm@...r.kernel.org" <kvm@...r.kernel.org>
Subject: Re: [PATCH] intel-iommu: Add device info into list before doing
context mapping
* Chris Wright (chrisw@...s-sol.org) wrote:
> * Hao, Xudong (xudong.hao@...el.com) wrote:
> > Yes, Chris, thanks your comments.
> > How about this one?
>
> Yes, it gets the locking right.
Sorry, I missed one other problem on the error path. You need to also
update pdev->dev.archdata.iommu to NULL (otherwise it is left pointing
to freed memory).
> Also makes host device and guest assigned device go through the same order:
>
> alloc_devinfo and init
> lock; place info on lists; unlock
> domain_context_mapping()
>
> The patch itself is whitespace damaged and does not apply. Please fix
> and feel free to add my:
>
> Acked-by: Chris Wright <chrisw@...s-sol.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists