linux-kernel - Re: [PATCH 15/16] dynamic_debug: factor vpr_info_dq out of ddebug_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111221213341.GC30393@redhat.com>
Date:	Wed, 21 Dec 2011 16:33:42 -0500
From:	Jason Baron <jbaron@...hat.com>
To:	greg@...ah.com, Bart Van Assche <bvanassche@....org>
Cc:	Jim Cromie <jim.cromie@...il.com>, joe@...ches.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 15/16] dynamic_debug: factor vpr_info_dq out of
 ddebug_parse_query

On Tue, Dec 20, 2011 at 03:49:54PM +0000, Bart Van Assche wrote:
> On Tue, Dec 20, 2011 at 3:47 PM, Jim Cromie <jim.cromie@...il.com> wrote:
> > On Tue, Dec 20, 2011 at 1:17 AM, Bart Van Assche <bvanassche@....org> wrote:
> > > On Mon, Dec 19, 2011 at 10:13 PM, Jason Baron <jbaron@...hat.com> wrote:
> > >> From: Jim Cromie <jim.cromie@...il.com>
> > >>
> > >> Factor pr_info(query) out of ddebug_parse_query, into pr_info_dq(),
> > >> for reuse later.  Also change the printed labels: file, func to agree
> > >> with the query-spec keywords accepted in the control file.  Pass ""
> > >> when string is null, to avoid "(null)" output from sprintf.  For
> > >> format print, use precision to skip last char, assuming its '\n', no
> > >> great harm if not, its a debug msg.
> > >
> > > pr_info_dq() or vpr_info_dq() ?
> >
> > I chose vpr_info_dq, with leading v to hint at the "if (verbose)" part
> 
> In case my reply was a little too terse: isn't there a letter "v"
> missing in the commit message ?
> 
> Bart.

Thanks for catching this.

Greg, if you want to s/pr_info_dq/vpr_info_dq, in the commit msg, this
one is all set.

Thanks,

-Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/