linux-kernel - RE: [PATCH 1/1] dt: reform for_each_property to for_each_property_of_node_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7FE21149F4667147B645348EC605788505C4B3@039-SN2MPN1-013.039d.mgd.msft.net>
Date:	Wed, 21 Dec 2011 03:02:15 +0000
From:	Dong Aisheng-B29396 <B29396@...escale.com>
To:	Rob Herring <robherring2@...il.com>
CC:	"devicetree-discuss@...ts.ozlabs.org" 
	<devicetree-discuss@...ts.ozlabs.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"grant.likely@...retlab.ca" <grant.likely@...retlab.ca>,
	Guo Shawn-R65073 <r65073@...escale.com>
Subject: RE: [PATCH 1/1] dt: reform for_each_property to
 for_each_property_of_node_of_node

> -----Original Message-----
> From: Rob Herring [mailto:robherring2@...il.com]
> Sent: Wednesday, December 21, 2011 2:50 AM
> To: Dong Aisheng-B29396
> Cc: devicetree-discuss@...ts.ozlabs.org; linux-kernel@...r.kernel.org; linux-
> arm-kernel@...ts.infradead.org; grant.likely@...retlab.ca; Guo Shawn-R65073
> Subject: Re: [PATCH 1/1] dt: reform for_each_property to
> for_each_property_of_node_of_node
> Importance: High
> 
> 
> On 12/20/2011 11:51 AM, Dong Aisheng wrote:
> > From: Dong Aisheng <dong.aisheng@...aro.org>
> >
> > Make this micro more easy to use(do not need to pass properties, a
> > node is
> 
> Make this macro easier to use...
> 
Acked.

> > enough), also change to a more sensible name as for_each_child_of_node.
> >
> > Signed-off-by: Dong Aisheng <dong.aisheng@...aro.org>
> > Cc: Grant Likely <grant.likely@...retlab.ca>
> > Cc: Rob Herring <rob.herring@...xeda.com>
> > Cc: Shawn Guo <shawn.guo@...escale.com>
> > ---
> >  drivers/of/base.c  |    2 +-
> >  include/linux/of.h |    4 ++--
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/of/base.c b/drivers/of/base.c index
> > 9b6588e..f6f6fe8 100644
> > --- a/drivers/of/base.c
> > +++ b/drivers/of/base.c
> > @@ -1159,7 +1159,7 @@ void of_alias_scan(void * (*dt_alloc)(u64 size, u64
> align))
> >  	if (!of_aliases)
> >  		return;
> >
> > -	for_each_property(pp, of_aliases->properties) {
> > +	for_each_property_of_node(of_aliases, pp) {
> >  		const char *start = pp->name;
> >  		const char *end = start + strlen(start);
> >  		struct device_node *np;
> > diff --git a/include/linux/of.h b/include/linux/of.h index
> > 4948552..f1a490c 100644
> > --- a/include/linux/of.h
> > +++ b/include/linux/of.h
> > @@ -219,8 +219,8 @@ extern int of_device_is_available(const struct
> > device_node *device);  extern const void *of_get_property(const struct
> device_node *node,
> >  				const char *name,
> >  				int *lenp);
> > -#define for_each_property(pp, properties) \
> > -	for (pp = properties; pp != NULL; pp = pp->next)
> > +#define for_each_property_of_node(dn, pp) \
> > +	for (pp = dn->properties; pp != NULL; pp = pp->next)
> 
> Probably should prepend it with "of_" while you're at it.
> 
I agree.
But it seems other help microes also do not with a "of_" prefix
Like for_each_child_of_node.
So I just follow the old convention.
Do you think I need to change this one firstly?

Regards
Dong Aisheng

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/