linux-kernel - RE: [RESEND PATCH] ARM: SAMSUNG: Add s3c_setparent_clksrc in s3c_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <061a01ccbf95$fe1e6960$fa5b3c20$%kim@samsung.com>
Date:	Wed, 21 Dec 2011 13:07:01 +0900
From:	Kukjin Kim <kgene.kim@...sung.com>
To:	jhbird.choi@...sung.com, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Cc:	'Ben Dooks' <ben-linux@...ff.org>,
	'Russell King' <linux@....linux.org.uk>, jhbird.choi@...il.com
Subject: RE: [RESEND PATCH] ARM: SAMSUNG: Add s3c_setparent_clksrc in
 s3c_set_clksrc

jhbird.choi@...sung.com wrote:
> 
> From: Jonghwan Choi <jhbird.choi@...sung.com>
> 
> Currently we have to run clk_set_parent to change clock source.
> But if there are sources & parent defined, it means we will select a
> parent
> in multiple clock sources. So sources & parent are already defined,
> set the parent clock int s3c_set_clksrc.
> Then we can reduce many clk_set_parent function in driver or setup_clock
> function.
> 
> Signed-off-by: Jonghwan Choi <jhbird.choi@...sung.com>
> ---
>  arch/arm/plat-samsung/clock-clksrc.c |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/plat-samsung/clock-clksrc.c b/arch/arm/plat-
> samsung/clock-clksrc.c
> index ae8b850..61dfe0d 100644
> --- a/arch/arm/plat-samsung/clock-clksrc.c
> +++ b/arch/arm/plat-samsung/clock-clksrc.c
> @@ -140,6 +140,14 @@ void __init_or_cpufreq s3c_set_clksrc(struct
> clksrc_clk *clk, bool announce)
>  		return;
>  	}
> 
> +	if (clk->sources && clk->clk.parent) {
> +		if (s3c_setparent_clksrc(&clk->clk, clk->clk.parent)) {
> +			printk(KERN_ERR "%s: bad source is %s\n",
> +					clk->clk.name, clk->clk.parent->name);
> +			return;
> +		}
> +	}
> +
>  	clksrc = __raw_readl(clk->reg_src.reg);
>  	clksrc &= mask;
>  	clksrc >>= clk->reg_src.shift;
> --
> 1.7.1

Hmm, I think, this  is not good. If there is a mux which includes clock sources, as you know, its parent clock can be selected
according to the value of reg_src and it should be changed by calling clk_set_parent() even though this can help in some kind of
view. And the clksrc_clk depends on SoC not board so the clk.parent cannot be fixed at the clock.c file.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@...sung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/