lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 22 Dec 2011 13:50:46 +0800 From: Li Zefan <lizf@...fujitsu.com> To: Mandeep Singh Baines <msb@...omium.org> CC: Tejun Heo <tj@...nel.org>, Frederic Weisbecker <fweisbec@...il.com>, linux-kernel@...r.kernel.org, containers@...ts.linux-foundation.org, cgroups@...r.kernel.org, KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>, Oleg Nesterov <oleg@...hat.com>, Andrew Morton <akpm@...ux-foundation.org>, Paul Menage <paul@...lmenage.org> Subject: Re: [PATCH 4/4] cgroup: remove extra calls to find_existing_css_set > @@ -2091,6 +2010,10 @@ int cgroup_attach_proc(struct cgroup *cgrp, struct task_struct *leader) > * rcu or tasklist locked. instead, build an array of all threads in the > * group - group_rwsem prevents new threads from appearing, and if > * threads exit, this will just be an over-estimate. > + * > + * While creating the list, also make sure css_sets exist for all > + * threads to be migrated. we use find_css_set, which allocates a new > + * one if necessary. > */ > group_size = get_nr_threads(leader); > /* flex_array supports very large thread-groups better than kmalloc. */ > @@ -2137,6 +2060,12 @@ int cgroup_attach_proc(struct cgroup *cgrp, struct task_struct *leader) > /* nothing to do if this task is already in the cgroup */ > if (ent.cgrp == cgrp) > continue; > + ent.cg = find_css_set(tsk->cgroups, cgrp); unfortunately This won't work, because we are holding tasklist_lock. > + if (!ent.cg) { > + retval = -ENOMEM; > + group_size = i; > + goto out_list_teardown; > + } > retval = flex_array_put(group, i, &ent, GFP_ATOMIC); > BUG_ON(retval != 0); > i++; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists