linux-kernel - Re: [PATCH] staging: asus_oled: Fixed checkpatch.pl warnings in asus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 22 Dec 2011 09:42:11 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Toon Schoenmakers <nighteyes1993@...il.com>
Cc:	sjakub@...il.com, gregkh@...e.de, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: asus_oled: Fixed checkpatch.pl warnings in
 asus_oled.c

On Tue, Dec 20, 2011 at 02:00:33PM +0100, Toon Schoenmakers wrote:
> >From ac6a96cdf890714ec7b8f0e6597f82a49cfbe232 Mon Sep 17 00:00:00 2001
> From: Toon Schoenmakers <nighteyes1993@...il.com>
> Date: Tue, 20 Dec 2011 13:52:41 +0100
> Subject: [PATCH] staging: asus_oled: Fixed checkpatch.pl warnings in
> asus_oled.c
> 

Insufficient patch description.

Patch mangled.  Read Documentation/email-clients.txt send it to
yourself, verify that it applies with `git am`.

> Signed-off-by: Toon Schoenmakers <nighteyes1993@...il.com>
> ---
> drivers/staging/asus_oled/asus_oled.c |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/asus_oled/asus_oled.c
> b/drivers/staging/asus_oled/asus_oled.c
> index 7bb7da7..e77e4e0 100644
> --- a/drivers/staging/asus_oled/asus_oled.c
> +++ b/drivers/staging/asus_oled/asus_oled.c
> @@ -201,7 +201,7 @@ static ssize_t set_enabled(struct device *dev,
> struct device_attribute *attr,
> struct usb_interface *intf = to_usb_interface(dev);
> struct asus_oled_dev *odev = usb_get_intfdata(intf);
> unsigned long value;
> - if (strict_strtoul(buf, 10, &value))
> + if (kstrtoul(buf, 10, &value))

We introduced a lot of new functions here so it's not just a one to
one translation from the old strict_strtoul().  For example
kstrtou8() might be more appropriate here because that's what gets
passed to enable_oled().  You would need to change the type for
value as well.

Althought it doesn't matter much.  If the user passes anything
besides 1 or 0, they deserve what they get I suppose.

Preserve the error code instead of returning -EINVAL for everything.

> return -EINVAL;

regards,
dan carpenter


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)