linux-kernel - Re: [PATCH] input: signedness bug in cma3000_thread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111222175020.GC21103@core.coreip.homeip.net>
Date:	Thu, 22 Dec 2011 09:50:20 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Xi Wang <xi.wang@...il.com>
Cc:	Valdis.Kletnieks@...edu,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] input: signedness bug in cma3000_thread_irq()

On Thu, Dec 15, 2011 at 05:17:02PM -0500, Xi Wang wrote:
> On Dec 14, 2011, at 10:21 PM, Valdis.Kletnieks@...edu wrote:
> > No, the variable that used to be a u8 - was it 8 bits wide for a reason?
> 
> The return value of CMA3000_READ?  I don't see any particular reason.  
> 

The data returned by CMA3000_READ() is a byte, so that's the reason (and
I am guessing here) that the author used u8 to store the result,
forgetting that the range was extended to report error conditions.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/