linux-kernel - Re: [RFC][PATCH 6/7] printk: Poke printk extra hard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFw_rQbOho8WojeiD3YZtzud99CAXZCzqoKNF1HRGXgnZA@mail.gmail.com>
Date:	Wed, 21 Dec 2011 17:17:21 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc:	"Ted Ts'o" <tytso@....edu>, Greg KH <greg@...ah.com>,
	Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	akpm@...ux-foundation.org,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [RFC][PATCH 6/7] printk: Poke printk extra hard

On Wed, Dec 21, 2011 at 2:57 AM, Peter Zijlstra <a.p.zijlstra@...llo.nl> wrote:
>
>
> +#ifdef CONFIG_PRINTK_DEBUG
> +void printk_init(void)
> +{
> +       struct rq *rq;
> +       unsigned long flags;
> +
> +       local_irq_save(flags);
> +       rq = this_rq();
> +       raw_spin_lock(&rq->lock);
> +       printk(KERN_DEBUG "printk: echo echo echo..\n");
> +       raw_spin_unlock(&rq->lock);
> +       local_irq_restore(flags);

Ok, I can't really say that I think this is worth a config option like this.

Maybe an example module or something?

And I don't know *why*, but my immediate reaction to the message was
that it either should be serious and say what it tested ("printk()
works under rq lock"), or it should say "Bork bork bork". "echo echo
echo" sounds just stupid.

                 Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/