linux-kernel - Re: [patch 4/5] x86, x2apic: allow "nox2apic" to disable x2apic mode setup by bios

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1324666889.4167.35.camel@sbsiddha-desk.sc.intel.com>
Date:	Fri, 23 Dec 2011 11:01:29 -0800
From:	Suresh Siddha <suresh.b.siddha@...el.com>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"flyboy@...il.com" <flyboy@...il.com>
Subject: Re: [patch 4/5] x86, x2apic: allow "nox2apic" to disable x2apic
 mode setup by bios

On Wed, 2011-12-21 at 23:24 -0800, Yinghai Lu wrote:
> On Wed, Dec 21, 2011 at 5:45 PM, Suresh Siddha
> <suresh.b.siddha@...el.com> wrote:
> 
> > @@ -1453,12 +1462,17 @@ static void disable_x2apic(void)
> >        if (msr & X2APIC_ENABLE) {
> >                u32 x2apic_id = read_apic_id();
> >
> > -               if (x2apic_id > 255)
> > -                       panic("Can not disable x2apic, id: %08x\n", x2apic_id);
> > +               if (x2apic_id >= 255)
> > +                       panic("Cannot disable x2apic, id: %08x\n", x2apic_id);
> 
> can not be applied cleanly.
> 
> update it a little bit.
> 
> need to use attached one to replace 4/5.
> 

Thanks Yinghai. updated patch look good.

Ingo, can you please queue this series to -tip?

thanks,
suresh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/