linux-kernel - Re: [PATCH 1/3] cgroup: remove tasklist_lock from cgroup_attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4EF3EA1C.4000806@cn.fujitsu.com>
Date:	Fri, 23 Dec 2011 10:40:28 +0800
From:	Li Zefan <lizf@...fujitsu.com>
To:	Frederic Weisbecker <fweisbec@...il.com>
CC:	Mandeep Singh Baines <msb@...omium.org>, Tejun Heo <tj@...nel.org>,
	linux-kernel@...r.kernel.org,
	containers@...ts.linux-foundation.org, cgroups@...r.kernel.org,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Oleg Nesterov <oleg@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Paul Menage <paul@...lmenage.org>
Subject: Re: [PATCH 1/3] cgroup: remove tasklist_lock from cgroup_attach_proc

>> diff --git a/kernel/cgroup.c b/kernel/cgroup.c
>> index 1042b3c..032139d 100644
>> --- a/kernel/cgroup.c
>> +++ b/kernel/cgroup.c
>> @@ -2102,21 +2102,6 @@ int cgroup_attach_proc(struct cgroup *cgrp, struct task_struct *leader)
>>  	if (retval)
>>  		goto out_free_group_list;
>>  
>> -	/* prevent changes to the threadgroup list while we take a snapshot. */
>> -	read_lock(&tasklist_lock);
>> -	if (!thread_group_leader(leader)) {
>> -		/*
>> -		 * a race with de_thread from another thread's exec() may strip
>> -		 * us of our leadership, making while_each_thread unsafe to use
>> -		 * on this task. if this happens, there is no choice but to
>> -		 * throw this task away and try again (from cgroup_procs_write);
>> -		 * this is "double-double-toil-and-trouble-check locking".
>> -		 */
>> -		read_unlock(&tasklist_lock);
>> -		retval = -EAGAIN;
>> -		goto out_free_group_list;
>> -	}
>> -
>>  	tsk = leader;
>>  	i = 0;
>>  	do {
>> @@ -2145,7 +2130,6 @@ int cgroup_attach_proc(struct cgroup *cgrp, struct task_struct *leader)
>>  	group_size = i;
>>  	tset.tc_array = group;
>>  	tset.tc_array_len = group_size;
>> -	read_unlock(&tasklist_lock);
> 
> You still need rcu_read_lock()/rcu_read_unlock() around
> 	do {
> 
> 	} while_each_thread()
> 
> because threadgroup_lock() doesn't lock the part that remove a thread from
> its group on exit.
> 

and inside rcu critical section, you can't call kmalloc(GFP_KERNEL)!!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/