linux-kernel - Re: [PATCH 1/1] usb: cdc-acm: Fix acm_tty_hangup() vs. acm_tty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 25 Dec 2011 22:43:09 +0100
From:	Thilo-Alexander Ginkel <thilo@...kel.com>
To:	oliver@...kum.name, gregkh@...e.de
Cc:	jhovold@...il.com, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] usb: cdc-acm: Fix acm_tty_hangup() vs.
 acm_tty_close() race

Hi there,

On Sat, Dec 17, 2011 at 10:55, Thilo-Alexander Ginkel <thilo@...kel.com> wrote:
> There is a race condition involving acm_tty_hangup() and acm_tty_close() where
> hangup() would attempt to access tty->driver_data without proper locking and
> NULL checking after close() has potentially already set it to NULL.
> One possibility to (sporadically) trigger this behavior is to perform a
> suspend/resume cycle with a running WWAN data connection.
>
> This patch addresses the issue by introducing a NULL check for
> tty->driver_data in acm_tty_hangup() protected by open_mutex and exiting
> gracefully when hangup() is invoked on a device that has already been closed.

just wondering: Is there any chance that this patch will make it into
3.3? I would really appreciate that as the bug it fixes is pretty
annoying (and potentially causes data loss when the laptop locks up on
resume) and I am sure that I am not the only one affected by it (at
least all Lenovo T420s with an Ericsson F5521gw WWAN modem should be
similarly affected).

If you would like to see any changes to the code or commit message
before considering the patch for inclusion, please let me know.

Thanks,
Thilo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/