linux-kernel - question about lqasc_release_port in drivers/tty/serial/lantiq.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 26 Dec 2011 18:42:17 +0100 (CET)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	alan@...ux.intel.com, linux-serial@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: question about lqasc_release_port in drivers/tty/serial/lantiq.c

The function lqasc_release_port in the file drivers/tty/serial/lantiq.c is 
defined as follows:

static void
lqasc_release_port(struct uart_port *port)
{
  	if (port->flags & UPF_IOREMAP) {
         	iounmap(port->membase);
 		port->membase = NULL;
 	}
}

But port->membase is initialized using devm_ioremap_nocache, implying that 
it should be freed with devm_ioremap.  devm_ioremap, however, requires an 
additional &pdev->dev argument.  Maybe the call to iounmap is not needed 
at all?

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/