linux-kernel - Re: [PATCH] tty: serial: imx: move del_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111226020017.GK8240@S2100-06.ap.freescale.net>
Date:	Mon, 26 Dec 2011 10:00:18 +0800
From:	Shawn Guo <shawn.guo@...escale.com>
To:	Eric Miao <eric.miao@...aro.org>
CC:	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	Fabio Estevam <fabio.estevam@...escale.com>,
	Shawn Guo <shawn.guo@...aro.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: [PATCH] tty: serial: imx: move del_timer_sync() to avoid
 potential deadlock

On Fri, Dec 23, 2011 at 05:39:27AM +0800, Eric Miao wrote:
> del_timer_sync() acquires its own lock and doesn't have to be nested
> within the spinlock of sport->port.lock in imx_set_termios(),  which
> will cause potential deadlock.  Fix this by moving it outside.
> 
> Cc: Fabio Estevam <fabio.estevam@...escale.com>
> Cc: Shawn Guo <shawn.guo@...aro.org>
> Cc: Sascha Hauer <s.hauer@...gutronix.de>
> Cc: Greg Kroah-Hartman <gregkh@...e.de>
> Signed-off-by: Eric Miao <eric.miao@...aro.org>

I queued this for 3.3, and will send a pull-request to Greg.

-- 
Regards,
Shawn

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/