| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20111227133952.GJ5344@tiehlicka.suse.cz> Date: Tue, 27 Dec 2011 14:39:52 +0100 From: Michal Hocko <mhocko@...e.cz> To: Hillf Danton <dhillf@...il.com> Cc: linux-mm@...ck.org, LKML <linux-kernel@...r.kernel.org>, Andrew Morton <akpm@...ux-foundation.org>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> Subject: Re: [PATCH] mm: hugetlb: add might_sleep() for gigantic page On Tue 27-12-11 21:38:59, Hillf Danton wrote: > On Tue, Dec 27, 2011 at 9:30 PM, Michal Hocko <mhocko@...e.cz> wrote: > > On Tue 27-12-11 21:21:18, Hillf Danton wrote: > >> On Tue, Dec 27, 2011 at 8:59 PM, Michal Hocko <mhocko@...e.cz> wrote: > >> > On Fri 23-12-11 21:41:08, Hillf Danton wrote: > >> >> From: Hillf Danton <dhillf@...il.com> > >> >> Subject: [PATCH] mm: hugetlb: add might_sleep() for gigantic page > >> >> > >> >> Like the case of huge page, might_sleep() is added for gigantic page, then > >> >> both are treated in same way. > >> > > >> > Why do we need to call might_sleep here? There is cond_resched in the > >> > loop... > >> > > >> > >> IIUC it is the reason to add... and the comment says > > > > cond_resched calls __might_sleep so there is no reason to call > > might_sleep outside the loop as well. > > > Yes, thanks. And remove it in the huge page case? Yes, makes sense. -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists