linux-kernel - Re: [PATCH -next] rcu: add missing __cpuinit annotation in rcutorture code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111227172951.GC2889@linux.vnet.ibm.com>
Date:	Tue, 27 Dec 2011 09:29:51 -0800
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Heiko Carstens <heiko.carstens@...ibm.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] rcu: add missing __cpuinit annotation in
 rcutorture code

On Tue, Dec 27, 2011 at 03:04:26PM +0100, Heiko Carstens wrote:
> "rcu: Add rcutorture CPU-hotplug capability" adds cpu hotplug operations
> to the rcutorture code but produces a false positive warning about section
> mismatches:
> 
> WARNING: vmlinux.o(.text+0x1e420c): Section mismatch in reference from the
> 	 function rcu_torture_onoff() to the function .cpuinit.text:cpu_up()
> 	 The function rcu_torture_onoff() references
> 	 the function __cpuinit cpu_up().
> 	 This is often because rcu_torture_onoff lacks a __cpuinit
> 	 annotation or the annotation of cpu_up is wrong.
> 
> Just add a __cpuinit annotation so the warning goes away.
> 
> Signed-off-by: Heiko Carstens <heiko.carstens@...ibm.com>

Thank you -- queued on my local -rcu tree.

							Thanx, Paul

> ---
>  kernel/rcutorture.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/rcutorture.c b/kernel/rcutorture.c
> index e29edc3..a58ac28 100644
> --- a/kernel/rcutorture.c
> +++ b/kernel/rcutorture.c
> @@ -1399,7 +1399,7 @@ rcu_torture_shutdown(void *arg)
>   * Execute random CPU-hotplug operations at the interval specified
>   * by the onoff_interval.
>   */
> -static int
> +static int __cpuinit
>  rcu_torture_onoff(void *arg)
>  {
>  	int cpu;
> @@ -1447,7 +1447,7 @@ rcu_torture_onoff(void *arg)
>  	return 0;
>  }
> 
> -static int
> +static int __cpuinit
>  rcu_torture_onoff_init(void)
>  {
>  	if (onoff_interval <= 0)
> -- 
> 1.7.7.3
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/