linux-kernel - Re: [PATCH v3 1/2] power: Charger-Manager: add initial Charger-Manager driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111227113611.GH2870@opensource.wolfsonmicro.com>
Date:	Tue, 27 Dec 2011 11:36:12 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Donggeun Kim <dg77.kim@...sung.com>
Cc:	linux-pm@...r.kernel.org, len.brown@...el.com, pavel@....cz,
	rjw@...k.pl, rdunlap@...otime.net, cbouatmailru@...il.com,
	pali.rohar@...il.com, prakity@...ell.com, lars@...afoo.de,
	kyungmin.park@...sung.com, myungjoo.ham@...sung.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] power: Charger-Manager: add initial
 Charger-Manager driver

On Tue, Dec 27, 2011 at 06:47:48PM +0900, Donggeun Kim wrote:

> +		/*
> +		 * Abnormal battery state - Stop charging forcibly,
> +		 * even if charger was enabled at the other places
> +		 */
> +		err = regulator_bulk_disable(desc->num_charger_regulators,
> +					desc->charger_regulators);
> +
> +		for (i = 0; i < desc->num_charger_regulators; i++) {
> +			if (regulator_is_enabled(
> +				    desc->charger_regulators[i].consumer)) {
> +				regulator_force_disable(
> +					desc->charger_regulators[i].consumer);
> +				dev_warn(cm->dev,
> +					"Disable regulator(%s) forcibly.\n",
> +					desc->charger_regulators[i].supply);
> +			}

Just implement a regulator_bulk_force_disable() operation; this is a
totally reasonable thing to want to do and other drivers may have the
same need.  Actually, looking at what you've written here it's totally
sensible and we should probably also roll the attempt to do a normal
disable() into force_disable() - there can't be many situations in which
trying a clean shutdown first isn't the right thing to do.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/