| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAJd=RBA70k8pCoP26hoJua=h1DHgx7eLHU0qrukJRxwoaxB65Q@mail.gmail.com> Date: Tue, 27 Dec 2011 21:21:18 +0800 From: Hillf Danton <dhillf@...il.com> To: Michal Hocko <mhocko@...e.cz> Cc: linux-mm@...ck.org, LKML <linux-kernel@...r.kernel.org>, Andrew Morton <akpm@...ux-foundation.org>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> Subject: Re: [PATCH] mm: hugetlb: add might_sleep() for gigantic page On Tue, Dec 27, 2011 at 8:59 PM, Michal Hocko <mhocko@...e.cz> wrote: > On Fri 23-12-11 21:41:08, Hillf Danton wrote: >> From: Hillf Danton <dhillf@...il.com> >> Subject: [PATCH] mm: hugetlb: add might_sleep() for gigantic page >> >> Like the case of huge page, might_sleep() is added for gigantic page, then >> both are treated in same way. > > Why do we need to call might_sleep here? There is cond_resched in the > loop... > IIUC it is the reason to add... and the comment says /** * might_sleep - annotation for functions that can sleep * * this macro will print a stack trace if it is executed in an atomic * context (spinlock, irq-handler, ...). * * This is a useful debugging help to be able to catch problems early and not * be bitten later when the calling function happens to sleep when it is not * supposed to. */ Thanks Hillf -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists