linux-kernel - linux-next: build failure after merge of the final tree (vfs tree related)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20111228193432.9dbab662b04a12a4ab29d6ba@canb.auug.org.au>
Date:	Wed, 28 Dec 2011 19:34:32 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Al Viro <viro@...iv.linux.org.uk>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: linux-next: build failure after merge of the final tree (vfs tree
 related)

Hi all,

After merging the final tree, today's linux-next build (sparc32 defconfig)
failed like this:

drivers/tty/sysrq.c: In function 'write_sysrq_trigger':
drivers/tty/sysrq.c:867:3: error: implicit declaration of function 'get_user' [-Werror=implicit-function-declaration]

Caused by commit b1cdabb05024 ("fs: move code out of buffer.c").
Presumably buffer_head.h was implictly including uaccess.h.

I have added the following patch:

From: Stephen Rothwell <sfr@...b.auug.org.au>
Date: Wed, 28 Dec 2011 19:28:15 +1100
Subject: [PATCH] sysreq.c needs uaccess.h for get_user

Commit b1cdabb05024 ("fs: move code out of buffer.c") removed the include
of linux/buffer_head.h which was presumably implictly including uaccess.h
on sparc32.

Fixes this build error:

drivers/tty/sysrq.c: In function 'write_sysrq_trigger':
drivers/tty/sysrq.c:867:3: error: implicit declaration of function 'get_user' [-Werror=implicit-function-declaration]

Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
---
 drivers/tty/sysrq.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c
index 4629801..7867b7c 100644
--- a/drivers/tty/sysrq.c
+++ b/drivers/tty/sysrq.c
@@ -40,6 +40,7 @@
 #include <linux/oom.h>
 #include <linux/slab.h>
 #include <linux/input.h>
+#include <linux/uaccess.h>
 
 #include <asm/ptrace.h>
 #include <asm/irq_regs.h>
-- 
1.7.8.197.g73c6b

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped