linux-kernel - Re: [PATCH] mm: vmscam: check page order in isolating lru pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4EFCA4F9.7070703@gmail.com>
Date:	Thu, 29 Dec 2011 12:35:53 -0500
From:	KOSAKI Motohiro <kosaki.motohiro@...il.com>
To:	Hillf Danton <dhillf@...il.com>
CC:	linux-mm@...ck.org, David Rientjes <rientjes@...gle.com>,
	Hugh Dickins <hughd@...gle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Michal Hocko <mhocko@...e.cz>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm: vmscam: check page order in isolating lru pages

(12/29/11 7:45 AM), Hillf Danton wrote:
> Before we try to isolate physically contiguous pages, check for page order is
> added, and if the reclaim order is no larger than page order, we should give up
> the attempt.
>
> Signed-off-by: Hillf Danton<dhillf@...il.com>
> Cc: Michal Hocko<mhocko@...e.cz>
> Cc: KAMEZAWA Hiroyuki<kamezawa.hiroyu@...fujitsu.com>
> Cc: Andrew Morton<akpm@...ux-foundation.org>
> Cc: David Rientjes<rientjes@...gle.com>
> Cc: Hugh Dickins<hughd@...gle.com>
> ---
>
> --- a/mm/vmscan.c	Thu Dec 29 20:20:16 2011
> +++ b/mm/vmscan.c	Thu Dec 29 20:28:14 2011
> @@ -1162,6 +1162,7 @@ static unsigned long isolate_lru_pages(u
>   		unsigned long end_pfn;
>   		unsigned long page_pfn;
>   		int zone_id;
> +		unsigned int isolated_pages = 0;
>
>   		page = lru_to_page(src);
>   		prefetchw_prev_lru_page(page, src, flags);
> @@ -1172,7 +1173,7 @@ static unsigned long isolate_lru_pages(u
>   		case 0:
>   			mem_cgroup_lru_del(page);
>   			list_move(&page->lru, dst);
> -			nr_taken += hpage_nr_pages(page);
> +			isolated_pages = hpage_nr_pages(page);
>   			break;
>
>   		case -EBUSY:
> @@ -1184,8 +1185,11 @@ static unsigned long isolate_lru_pages(u
>   			BUG();
>   		}
>
> +		nr_taken += isolated_pages;
>   		if (!order)
>   			continue;
> +		if (isolated_pages != 1&&  isolated_pages>= (1<<  order))
> +			continue;

strange space alignment. and I don't think we need "isolated_pages != 1" 
check.

Otherwise, Looks good to me.

Acked-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/