linux-kernel - Re: [PATCH] btree: Export btree_get_prev() so modules can use btree_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111230093638.GC26473@logfs.org>
Date:	Fri, 30 Dec 2011 10:36:38 +0100
From:	Jörn Engel <joern@...fs.org>
To:	Roland Dreier <roland@...nel.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Steve Hodgson <steve@...estorage.com>
Subject: Re: [PATCH] btree: Export btree_get_prev() so modules can use
	btree_for_each

On Wed, 28 December 2011 00:53:59 -0800, Roland Dreier wrote:
> 
> From: Steve Hodgson <steve@...estorage.com>
> 
> The btree_for_each API is implemented with macros that internally call
> btree_get_prev(), so if btree_get_prev() isn't exported then modules
> fail to link if they try to use one of the btree_for_each macros.  Since
> the rest of the btree API is exported, we should keep things orthogonal
> and make this work too.
> 
> Cc: Joern Engel <joern@...fs.org>
> Signed-off-by: Roland Dreier <roland@...estorage.com>

Acked-by: Joern Engel <joern@...fs.org>

> ---
>  lib/btree.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/lib/btree.c b/lib/btree.c
> index 2a34392..e5ec1e9 100644
> --- a/lib/btree.c
> +++ b/lib/btree.c
> @@ -357,6 +357,7 @@ miss:
>  	}
>  	return NULL;
>  }
> +EXPORT_SYMBOL_GPL(btree_get_prev);
>  
>  static int getpos(struct btree_geo *geo, unsigned long *node,
>  		unsigned long *key)
> -- 
> 1.7.5.4
> 

Jörn

-- 
"Error protection by error detection and correction."
-- from a university class
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/