linux-kernel - Re: [PATCH v6 09/11] virtio: net: Add freeze, restore handlers to support S4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120101114727.GC25350@redhat.com>
Date:	Sun, 1 Jan 2012 13:47:27 +0200
From:	"Michael S. Tsirkin" <mst@...hat.com>
To:	Amit Shah <amit.shah@...hat.com>
Cc:	Virtualization List <virtualization@...ts.linux-foundation.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH v6 09/11] virtio: net: Add freeze, restore handlers to
 support S4

On Fri, Dec 30, 2011 at 03:08:19PM +0530, Amit Shah wrote:
> > 
> > > +	if (!try_fill_recv(vi, GFP_KERNEL))
> > > +		schedule_delayed_work(&vi->refill, 0);
> > 
> > This needs to be switched to non reentrant wq too?
> 
> Subsequent invocations could create problems?  Note that this will be
> the first item to be queued in the workqueue for the refill work.
> 
> 		Amit

See recent patches on net-next.
We switched other calls to a non reentrant wq so I think same
reasoning applies there.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/