lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 1 Jan 2012 13:22:34 +0100
From:	Oliver Neukum <>
To:	Alan Stern <>
Cc:	Matthew Garrett <>,
	Linus Torvalds <>,
	Dave Jones <>,
	Linux Kernel <>,
	Larry Finger <>,
	Chaoming Li <>,
	"John W. Linville" <>,
	"Greg Kroah-Hartman" <>,
	USB list <>,
	Linux Wireless List <>
Subject: Re: loading firmware while usermodehelper disabled.

Am Sonntag, 1. Januar 2012, 03:21:45 schrieb Alan Stern:
> On Sat, 31 Dec 2011, Oliver Neukum wrote:

> > We are definitely going through do_unbind_rebind(). But I don't think
> > it matters why we got there. We seem to be calling probe() too early.
> > And we need to guarantee that a driver can request firmware in probe()
> > 
> > So something has changed in the resume code path further up.
> For at least a year and a half, it has been true that rebinding takes

Yes, so I don't understand why we haven't been hitting this issue
all that time.

> place during the complete phase of system resume.  Clearly that is too 
> early to load firmware.  When do you think we should do it instead?

I think we ought to delay until right after user space is unfrozen.
The devices are gone anyway, so we lose nothing but have the ability
to call helpers.
> And how should we keep track of which interfaces need rebinding?

I guess this calls for a brute force approach. We can kick khubd and have
it walk all busses checking for  needs_binding.

> P.S.: Oliver, it looks like there's a bunch of dead code in
> usb_suspend_interface() and usb_resume_interface().  I don't see how
> either one can be executed with a driver that doesn't have both suspend
> and resume methods.  Such cases should be filtered out when
> usb_suspend() calls do_unbind_rebind().  The only odd thing that can
> happen is when a driver doesn't support reset-resume.  Do you agree?

I agree.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists