lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 1 Jan 2012 15:22:07 +0100 From: Linus Walleij <linus.walleij@...aro.org> To: Haojian Zhuang <haojian.zhuang@...vell.com> Cc: swarren@...dia.com, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, eric.y.miao@...il.com, linux@....linux.org.uk, arnd@...db.de Subject: Re: [PATCH v3 3/3] gpio: pxa: request pinmux function for gpio On Thu, Dec 22, 2011 at 9:17 AM, Haojian Zhuang <haojian.zhuang@...vell.com> wrote: > While gpio is requested for pxa, gpio driver will request function ready > on pin. (...) > +#ifdef CONFIG_PINMUX > +static int pxa_gpio_request(struct gpio_chip *chip, unsigned offset) > +{ > + return pinmux_request_gpio(chip->base + offset); > +} > + > +static void pxa_gpio_free(struct gpio_chip *chip, unsigned offset) > +{ > + pinmux_free_gpio(chip->base + offset); > +} > +#else > +static int pxa_gpio_request(struct gpio_chip *chip, unsigned offset) {return 0;} > +static void pxa_gpio_free(struct gpio_chip *chip, unsigned offset) {} > +#endif > + Skip the #ifdef, the pinmux portion of pinctrl already provides stubs if CONFIG_PINMUX is not selected. See <linux/pinctrl/pinmux.h> Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists