linux-kernel - Re: loading firmware while usermodehelper disabled.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120102221235.GA16012@srcf.ucam.org>
Date:	Mon, 2 Jan 2012 22:12:36 +0000
From:	Matthew Garrett <mjg@...hat.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Jack Stone <jwjstone@...tmail.fm>,
	Alan Stern <stern@...land.harvard.edu>,
	Oliver Neukum <oliver@...kum.org>,
	Dave Jones <davej@...hat.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Larry Finger <Larry.Finger@...inger.net>,
	Chaoming Li <chaoming_li@...lsil.com.cn>,
	"John W. Linville" <linville@...driver.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	USB list <linux-usb@...r.kernel.org>,
	Linux Wireless List <linux-wireless@...r.kernel.org>
Subject: Re: loading firmware while usermodehelper disabled.

On Mon, Jan 02, 2012 at 02:03:27PM -0800, Linus Torvalds wrote:
> On Mon, Jan 2, 2012 at 1:50 PM, Matthew Garrett <mjg@...hat.com> wrote:
> > On Mon, Jan 02, 2012 at 01:27:03PM -0800, Linus Torvalds wrote:
> >
> >> If we didn't load the firmware before the suspend, then the resume
> >> function of a device sure as hell had better not load it at resume
> >> time either.
> >
> > If the hardware has lost its state then refusing to load the firmware at
> > resume time isn't going to leave you with a working device.
> 
> What the heck is your problem?
> 
> Go back and read it.
> 
> If it wasn't loaded before, THEN IT WASN'T WORKING BEFORE EITHER! And
> if it was loaded before, then it would be cached (and thus trivially
> reloaded without having to invoke user-space or disk devices that may
> not be running) and thus loading it would work.

The kernel that loaded the firmware to make the device work is not 
required to be the same kernel that we're running when we suspend. The 
hardware keeps its firmware over warm reboots, and if it already has 
loaded firmware then we have no way of knowing that it needs firmware at 
all.

-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/