linux-kernel - Re: [096/104] rtc: Disable the alarm in the hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120103162720.GA22050@elie.hsd1.il.comcast.net>
Date:	Tue, 3 Jan 2012 10:27:20 -0600
From:	Jonathan Nieder <jrnieder@...il.com>
To:	Greg KH <gregkh@...e.de>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	rtc-linux@...glegroups.com, torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org, alan@...rguk.ukuu.org.uk,
	John Stultz <john.stultz@...aro.org>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	Rabin Vincent <rabin.vincent@...ricsson.com>,
	"Antonio-M. Corbi Bellot" <antonio.corbi@...es>,
	Marco Santos <marco.santos@...next.com>,
	Christophe Vu-Brugier <cvubrugier@...oo.fr>
Subject: Re: [096/104] rtc: Disable the alarm in the hardware

Hi Greg,

Greg KH wrote:

> 3.1-stable review patch.  If anyone has any objections, please let me know.
>
> ------------------
>
> From: Rabin Vincent <rabin.vincent@...ricsson.com>
>
> commit c0afabd3d553c521e003779c127143ffde55a16f upstream.
>
> Currently, the RTC code does not disable the alarm in the hardware.
>
> This means that after a sequence such as the one below (the files are in the
> RTC sysfs), the box will boot up after 2 minutes even though we've
> asked for the alarm to be turned off.
[...]
> Fix this by disabling the alarm when there are no timers to run.

Seems to cause a regression.  On the affected kernels (e.g., 3.1.5,
3.1.6, and 3.2-rc7) the patch has exactly the opposite of what you'd
expect --- the affected machines automatically power on a few minutes
after shutdown if and only if the patch is applied.

The affected machines all seem to be Toshiba Portege laptops.

 Antonio-M. Corbi Bellot: Toshiba Portege R500
 Marco Santos: Toshiba Portege Z830
 Christophe Vu-Brugier: Toshiba Portege R830

Christophe tried reverting the above patch and the symptoms went away.
See http://bugs.debian.org/652869 for details.  Please consider
reverting the patch from stable until this is resolved.

Thanks,
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/