linux-kernel - Re: [PATCH 2/2] tty: rework pty count limiting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120103004325.0014b646@pyramind.ukuu.org.uk>
Date:	Tue, 3 Jan 2012 00:43:25 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Konstantin Khlebnikov <khlebnikov@...nvz.org>
Cc:	Greg KH <gregkh@...e.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] tty: rework pty count limiting

> > That's a userspace api change, why is this going to be allowed?
> 
> open() can return -ENOSPC in case normal fs,
> meanwhile error codes for /dev/ptmx wasn't documented at all:
> there is nothing in manpage pts, pty and ptmx.
> manpage posix_openpt and getpt refers to manpage open(2).
> I can return EIO back, if this is critical.

I prefer the -ENOSPC change - its perfectly within POSIX and while its
vaguely an ABI change I don't believe its one that a single piece of
software actually cares about. So nothing will break (famous last words).

Lets try it and see.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/