linux-kernel - Re: [PATCH] deadlock with suspend and quotas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.1201031318590.10105@hs20-bc2-1.build.redhat.com>
Date:	Tue, 3 Jan 2012 13:22:22 -0500 (EST)
From:	Mikulas Patocka <mpatocka@...hat.com>
To:	Al Viro <viro@...IV.linux.org.uk>
cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	Jan Kara <jack@...e.cz>, dm-devel@...hat.com
Subject: Re: [PATCH] deadlock with suspend and quotas



On Tue, 3 Jan 2012, Al Viro wrote:

> On Fri, Nov 25, 2011 at 03:25:16PM -0500, Mikulas Patocka wrote:
> 
> > The following patch fixes the deadlock. When the quota subsystem takes s_umount,
> > it checks if the filesystem is frozen. If it is, we drop s_umount, wait for
> > the filesystem to resume and retry.
> > 
> > Signed-off-by: Mikulas Patocka <mpatocka@...hat.com>
> > CC: stable@...nel.org
> 
> So basically you want a variant of get_super() that would get you a
> superblock for this bdev, locked and unfrozen?  Fair enough, but
> 	* that should be a proper helper in super.c, rather than
> open-coded in fs/quota/quota.c, of all places
> 	* what about other existing callers get_super() and its friends?

Hi

You can look at that functionality here: I've already made a patch that 
has it: 
https://www.redhat.com/archives/dm-devel/2011-November/msg00151.html

Basically, the patch introduces a function down_read_s_umount, which takes 
s_umount for read, but makes sure that the filesystem is not frozen. Then, 
it adds a boolean parameter to get_super() which tells get_super() that it 
should wait for unfreeze (i.e. call "down_read_s_umount" isntead of 
"down_read(&sb->s_umount)").

Mikulas

> and while we are at it, why in damnation name is it exported?  The only
> caller outside of core VFS is under #if 0...
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/