linux-kernel - Re: [PATCH v5 8/8] mm: add vmstat counters for tracking PCP drains

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F037D84.5070502@gmail.com>
Date:	Tue, 03 Jan 2012 17:13:24 -0500
From:	KOSAKI Motohiro <kosaki.motohiro@...il.com>
To:	Gilad Ben-Yossef <gilad@...yossef.com>
CC:	linux-kernel@...r.kernel.org, Christoph Lameter <cl@...ux.com>,
	Chris Metcalf <cmetcalf@...era.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Frederic Weisbecker <fweisbec@...il.com>, linux-mm@...ck.org,
	Pekka Enberg <penberg@...nel.org>,
	Matt Mackall <mpm@...enic.com>,
	Sasha Levin <levinsasha928@...il.com>,
	Rik van Riel <riel@...hat.com>,
	Andi Kleen <andi@...stfloor.org>, Mel Gorman <mel@....ul.ie>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Avi Kivity <avi@...hat.com>
Subject: Re: [PATCH v5 8/8] mm: add vmstat counters for tracking PCP drains

(1/3/12 2:00 PM), Gilad Ben-Yossef wrote:
> 2012/1/3 KOSAKI Motohiro<kosaki.motohiro@...il.com>:
>> (1/2/12 5:24 AM), Gilad Ben-Yossef wrote:
>>> This patch introduces two new vmstat counters: pcp_global_drain
>>> that counts the number of times a per-cpu pages global drain was
>>> requested and pcp_global_ipi_saved that counts the number of times
>>> the number of CPUs with per-cpu pages in any zone were less then
>>> 1/2 of the number of online CPUs.
>>>
>>> The patch purpose is to show the usefulness of only sending an IPI
>>> asking to drain per-cpu pages to CPUs that actually have them
>>> instead of a blind global IPI. It is probably not useful by itself.
> ...
>
>               }
>>>        on_each_cpu_mask(cpus_with_pcps, drain_local_pages, NULL, 1);
>>> +
>>> +     count_vm_event(PCP_GLOBAL_DRAIN);
>>> +     if (cpumask_weight(cpus_with_pcps)<    (cpumask_weight(cpu_online_mask) / 2))
>>> +             count_vm_event(PCP_GLOBAL_IPI_SAVED);
>>
>> NAK.
>>
>> PCP_GLOBAL_IPI_SAVED is only useful at development phase. I can't
>> imagine normal admins use it.
>
> As the description explains, the purpose of the patch is to show why i
> claim the previous
> patch is useful. I did not meant it to be applied to mainline. My
> apologies for not
> stating this more clearly. I agree it is not useful for an admin,
> although perhaps PCP_GLOBAL_DRAIN
> alone might - I am not sure?

Until we found a good usecase, we shouldn't append any stat. It is not
zero overhead even though nobody uses.

That's why I almost always disagree adding statistics from point of 
developers view.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/